feat: convert FileMetaData to ParquetMetaData
#2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2980 +/- ##
===========================================
- Coverage 85.85% 85.24% -0.62%
===========================================
Files 775 784 +9
Lines 124707 126760 +2053
===========================================
+ Hits 107070 108053 +983
- Misses 17637 18707 +1070 |
fengys1996
reviewed
Dec 25, 2023
Co-authored-by: fys <[email protected]>
evenyag
reviewed
Dec 25, 2023
Co-authored-by: Yingwen <[email protected]>
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Dec 26, 2023
* feat: convert `FileMetaData` to `ParquetMetaData` (GreptimeTeam#2980) * feat: can convert Format FileMetaData to ParquetMetaData * test: parquet metadata equal * chore: test * chore: cr comment Co-authored-by: fys <[email protected]> * chore: cr comment * refactor: type name * chore: cr comment Co-authored-by: Yingwen <[email protected]> --------- Co-authored-by: fys <[email protected]> Co-authored-by: Yingwen <[email protected]> * refactor(remote_wal): add StandaloneWalConfig (GreptimeTeam#3002) * feat: integrate remote wal to standalone * fix: test * refactor: refactor standalone wal config * chore: change default kafka port to 9092 * chore: apply suggestions from CR --------- Co-authored-by: niebayes <[email protected]> --------- Co-authored-by: Wei <[email protected]> Co-authored-by: fys <[email protected]> Co-authored-by: Yingwen <[email protected]> Co-authored-by: Weny Xu <[email protected]> Co-authored-by: niebayes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
part of #2963 , this pr is pre-work.
support to convert from
FileMetaDatatoParquetMetaData.Checklist
Refer to a related PR or issue link (optional)
#2963