-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export runtime metric to promethues #2985
Conversation
29a6aaf
to
de1f340
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2985 +/- ##
===========================================
- Coverage 85.87% 85.24% -0.63%
===========================================
Files 780 783 +3
Lines 126184 126638 +454
===========================================
- Hits 108356 107954 -402
- Misses 17828 18684 +856 |
@MichaelScofield PTAL |
@SSebo can you attach some output as an example to illustrate the tokio runtime metrics look like? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you @SSebo .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to sort the deps.
Head branch was pushed to by a user without write access
65892ca
to
fb73057
Compare
Of course. How about this ? assert!(metric_text.contains("runtime_0_tokio_budget_forced_yield_count 0"));
assert!(metric_text.contains("runtime_0_tokio_injection_queue_depth 0"));
assert!(metric_text.contains("runtime_0_tokio_workers_count 5")); |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
export tokio runtime metrics
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #1529