Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: "fix: revert unfinished route table change" #3009

Merged
merged 1 commit into from
Dec 27, 2023
Merged

chore: "fix: revert unfinished route table change" #3009

merged 1 commit into from
Dec 27, 2023

Conversation

MichaelScofield
Copy link
Collaborator

Reverts #3008

@MichaelScofield MichaelScofield added the docs-not-required This change does not impact docs. label Dec 26, 2023
@github-actions github-actions bot removed the docs-not-required This change does not impact docs. label Dec 26, 2023
waynexia
waynexia approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This breaks the existing metric engine functionalities.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (d061bf3) 85.63% compared to head (d2dff2e) 85.66%.
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3009      +/-   ##
===========================================
+ Coverage    85.63%   85.66%   +0.03%     
===========================================
  Files          784      784              
  Lines       126824   126860      +36     
===========================================
+ Hits        108606   108678      +72     
+ Misses       18218    18182      -36

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 27, 2023
Merged via the queue into develop with commit eadde72 Dec 27, 2023
21 of 22 checks passed
@MichaelScofield MichaelScofield deleted the revert-3008-revert-route-table branch December 27, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelScofield @waynexia @WenyXu