-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote_wal): append a noop record after kafka topic initialization #3040
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
==========================================
- Coverage 85.50% 85.04% -0.46%
==========================================
Files 793 793
Lines 128447 128481 +34
==========================================
- Hits 109825 109264 -561
- Misses 18622 19217 +595 |
non-blocking: We might need to get the LEO before producing a no-op record. Or there will be one no-op record each time the metasrv starts. For LEO, refer to this |
c99bbda
to
e0397c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Append a noop record after kafka topic initialization.
If the EntryId starts from 0, then the first entry in the mito engine will be dropped after restart. The mito always replays the memtable from the
flushed id + 1
(i.e., 0+1=1). Therefore, The EntryId must start from 1.Checklist
Refer to a related PR or issue link (optional)
close #3039