-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optimize export metric behavior #3047
fix: Optimize export metric behavior #3047
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
==========================================
- Coverage 85.76% 85.18% -0.58%
==========================================
Files 791 805 +14
Lines 127985 131093 +3108
==========================================
+ Hits 109760 111674 +1914
- Misses 18225 19419 +1194 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almostly LGTM
@v0y4g3r @fengjiachun PTAL |
I wholeheartedly agree with the configuration mentioned by @killme2008. Frankly speaking, it would be hard for me to hit the Approve button if we didn't follow through with this approach. 🥲 Here are my opinions: |
In my original idea, I did retain the design of using the entire url as a parameter, for greater compatibility. In the subsequent review, the parameters are split to But as for distinguishing the two import methods (i.e. How about yours opinion? @killme2008 @zhongzc |
Yes, totally agree with the URL as configured parameter instead of Considering that |
89a8c9a
to
7367adb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Optimize export metric behavior in pr #2928
Please explain IN DETAIL what the changes are in this PR and why they are needed:
ExportMetricHandler
information_schema
after solve Duplicate information_schema #2976About discuss on #2972
Because
GreptimeDBTelemetryTask
inmetasrv
is a bit complicate, so we’ll discuss it laterChecklist
Refer to a related PR or issue link (optional)
Closes #2975