Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump opendal to 0.44 #3058

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 31, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Bump opendal to 0.44

The next minor version(0.44.1), a BufferReader(apache/opendal#3735) will be introduced.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (96b6235) 85.66% compared to head (898c0d3) 85.17%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3058      +/-   ##
==========================================
- Coverage   85.66%   85.17%   -0.50%     
==========================================
  Files         806      806              
  Lines      131563   131661      +98     
==========================================
- Hits       112707   112144     -563     
- Misses      18856    19517     +661     

@WenyXu WenyXu marked this pull request as draft January 2, 2024 10:27
@WenyXu WenyXu self-assigned this Jan 3, 2024
@WenyXu WenyXu marked this pull request as ready for review January 4, 2024 12:13
@WenyXu WenyXu force-pushed the chore/upgrade-opendal-0_44 branch from 88e0468 to 8b863c1 Compare January 4, 2024 12:19
@WenyXu WenyXu force-pushed the chore/upgrade-opendal-0_44 branch from 8b863c1 to c296b55 Compare January 4, 2024 13:05
src/mito2/src/cache/file_cache.rs Outdated Show resolved Hide resolved
src/mito2/src/cache/file_cache.rs Outdated Show resolved Hide resolved
src/object-store/src/layers/lru_cache/read_cache.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Jan 5, 2024

@evenyag @killme2008 PTAL

@WenyXu WenyXu force-pushed the chore/upgrade-opendal-0_44 branch from c444df9 to e9b1fa0 Compare January 5, 2024 06:50
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Jan 5, 2024
Merged via the queue into GreptimeTeam:main with commit e0a43f3 Jan 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants