Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kafka wal integration test utils #3069

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 2, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add kafka wal integration test utils

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 2, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f735f73) 85.35% compared to head (8b48624) 84.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
- Coverage   85.35%   84.82%   -0.54%     
==========================================
  Files         800      800              
  Lines      129395   129602     +207     
==========================================
- Hits       110441   109929     -512     
- Misses      18954    19673     +719     

Merged via the queue into GreptimeTeam:main with commit d87ab06 Jan 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants