-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add bound check for raft-engine logstore #3073
Merged
v0y4g3r
merged 6 commits into
GreptimeTeam:main
from
v0y4g3r:chore/raft-engine-bound-check
Jan 9, 2024
Merged
chore: add bound check for raft-engine logstore #3073
v0y4g3r
merged 6 commits into
GreptimeTeam:main
from
v0y4g3r:chore/raft-engine-bound-check
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Size: M
and removed
docs-not-required
This change does not impact docs.
Size: S
labels
Jan 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 85.59% 85.10% -0.49%
==========================================
Files 815 815
Lines 133334 133380 +46
==========================================
- Hits 114123 113509 -614
- Misses 19211 19871 +660 |
evenyag
reviewed
Jan 4, 2024
evenyag
reviewed
Jan 4, 2024
v0y4g3r
force-pushed
the
chore/raft-engine-bound-check
branch
from
January 4, 2024 15:10
8e7b065
to
63f7e8d
Compare
evenyag
reviewed
Jan 5, 2024
evenyag
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
v0y4g3r
force-pushed
the
chore/raft-engine-bound-check
branch
from
January 9, 2024 06:32
5287c50
to
b30f20b
Compare
MichaelScofield
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DLJB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds bound check to RaftEngine logstore so that it won't panic at "memtable has a hole". This will also helps to diagnose some weird out-of-order sequence in some user cases.
Note: this impose extra constraint to prevent concurrent writes with consecutive entry id to the same region when bound check and actual write overlap. But it won't cause false errors in region worker pattern where only one thread writes to some region.
Performance impact
Ran performance regression test in TSBS suite and no noticeable changes observed.
Checklist
Refer to a related PR or issue link (optional)
Closes #3042