Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(remote_wal): add kafka image for integration test #3074

Closed
wants to merge 2 commits into from

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Added a Kafka image for integration test. This image is powered by testcontainers with which you can start a Kafka container. When the container is started, you can assume there's a Kafka cluster ready to be used.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jan 3, 2024
@niebayes niebayes added the docs-not-required This change does not impact docs. label Jan 3, 2024
@niebayes niebayes self-assigned this Jan 3, 2024
@niebayes niebayes mentioned this pull request Jan 3, 2024
14 tasks
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.72%. Comparing base (2e686fe) to head (96ea2e7).
Report is 325 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3074      +/-   ##
==========================================
+ Coverage   85.47%   85.72%   +0.24%     
==========================================
  Files         801      813      +12     
  Lines      129967   133092    +3125     
==========================================
+ Hits       111095   114096    +3001     
- Misses      18872    18996     +124     

src/common/test-util/Cargo.toml Outdated Show resolved Hide resolved
src/common/test-util/Cargo.toml Outdated Show resolved Hide resolved
@niebayes niebayes changed the title test(remote_wal): add kafka image for testing purpose test(remote_wal): add kafka image for integration test Jan 9, 2024
@niebayes niebayes requested a review from WenyXu January 9, 2024 03:35
@WenyXu WenyXu marked this pull request as draft January 9, 2024 06:56
@WenyXu
Copy link
Member

WenyXu commented Jan 9, 2024

Let's convert it to a draft and add it when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants