Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for lease keeper with logical table #3096

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add tests for lease keeper handling logical table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d973cf8) 85.69% compared to head (de6567c) 85.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
- Coverage   85.69%   85.27%   -0.42%     
==========================================
  Files         806      806              
  Lines      131511   131548      +37     
==========================================
- Hits       112699   112179     -520     
- Misses      18812    19369     +557     

@WenyXu WenyXu force-pushed the test/lease-keeper branch from 31ebb32 to de6567c Compare January 4, 2024 09:43
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 5, 2024
Merged via the queue into GreptimeTeam:main with commit 342faa4 Jan 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants