Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print detailed error #3146

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 11, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix missing detailed error

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

fixes #3138

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8ec1e42) 85.41% compared to head (a3ff077) 84.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   85.41%   84.94%   -0.48%     
==========================================
  Files         823      823              
  Lines      134797   134917     +120     
==========================================
- Hits       115138   114599     -539     
- Misses      19659    20318     +659     

@WenyXu WenyXu added the O-chaos Found by chaos tests label Jan 11, 2024
@WenyXu WenyXu mentioned this pull request Jan 12, 2024
5 tasks
@WenyXu WenyXu marked this pull request as draft January 12, 2024 03:06
@WenyXu WenyXu marked this pull request as ready for review January 12, 2024 03:42
@WenyXu WenyXu requested a review from waynexia January 12, 2024 03:56
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Jan 12, 2024
Merged via the queue into GreptimeTeam:main with commit bf96ce3 Jan 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. O-chaos Found by chaos tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detail error didn't print during the procedure execution
3 participants