Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: batch create ddl #3194

Merged
merged 3 commits into from
Jan 26, 2024
Merged

feat: batch create ddl #3194

merged 3 commits into from
Jan 26, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Jan 18, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Batch create logical tables with procedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Jan 18, 2024
@fengjiachun fengjiachun changed the title feat: batch ddl feat: batch create ddl Jan 18, 2024
@fengjiachun fengjiachun marked this pull request as draft January 18, 2024 12:06
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 413 lines in your changes are missing coverage. Please review.

Comparison is base (8bade8f) 85.79% compared to head (58be92f) 85.16%.

❗ Current head 58be92f differs from pull request most recent head 220a70a. Consider uploading reports for the commit 220a70a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   85.79%   85.16%   -0.64%     
==========================================
  Files         848      850       +2     
  Lines      139148   139916     +768     
==========================================
- Hits       119388   119155     -233     
- Misses      19760    20761    +1001

@github-actions github-actions bot added Size: XL and removed Size: L labels Jan 18, 2024
@fengjiachun fengjiachun marked this pull request as ready for review January 19, 2024 12:11
@fengjiachun fengjiachun requested review from waynexia, MichaelScofield and WenyXu and removed request for waynexia and MichaelScofield January 19, 2024 12:14
@fengjiachun fengjiachun force-pushed the feat/batch-ddl branch 2 times, most recently from c2bb5ab to 01785fe Compare January 19, 2024 14:13
fengjiachun
fengjiachun commented Jan 19, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
WenyXu
WenyXu reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take a look the rest later...

src/operator/src/statement/ddl.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_name.rs Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/key.rs Show resolved Hide resolved
src/common/meta/src/ddl/table_meta.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
WenyXu
WenyXu reviewed Jan 24, 2024
View reviewed changes
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_tables.rs Outdated Show resolved Hide resolved
@fengjiachun fengjiachun requested a review from WenyXu January 24, 2024 10:37
@fengjiachun
Copy link
Collaborator Author

@WenyXu PTAL

WenyXu
WenyXu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator Author

@MichaelScofield PTAL

MichaelScofield
MichaelScofield reviewed Jan 25, 2024
View reviewed changes
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_logical_tables.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl_manager.rs Outdated Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/ddl.rs Outdated Show resolved Hide resolved
src/common/meta/src/rpc/ddl.rs Outdated Show resolved Hide resolved
@fengjiachun fengjiachun force-pushed the feat/batch-ddl branch 4 times, most recently from 2956844 to 58be92f Compare January 25, 2024 15:26
@fengjiachun
feat: return table ids
b0f1e5e 
chore: by comment

chore: remove wal_options

chore: create logical tables lock key

feat: get metadata in procedure
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 26, 2024
Merged via the queue into GreptimeTeam:main with commit 1fab7ab Jan 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengjiachun @MichaelScofield @WenyXu