refactor: allocate table id in the procedure #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3271 +/- ##
==========================================
- Coverage 85.26% 84.87% -0.39%
==========================================
Files 881 883 +2
Lines 143843 144014 +171
==========================================
- Hits 122641 122226 -415
- Misses 21202 21788 +586 |
github-actions
bot
added
docs-not-required
WenyXu
force-pushed
the
enhance/create-table-ddl-procedure
branch
2 times, most recently
from
f9cea39 to
c3c7a03
Compare
WenyXu
requested review from
killme2008,
MichaelScofield,
fengjiachun and
niebayes
WenyXu
force-pushed
the
enhance/create-table-ddl-procedure
branch
from
c3c7a03 to
d52307b
Compare
WenyXu
force-pushed
the
enhance/create-table-ddl-procedure
branch
from
d52307b to
0d58b1f
Compare
3 tasks
fengjiachun
reviewed
Feb 18, 2024
WenyXu
force-pushed
the
enhance/create-table-ddl-procedure
branch
from
949511a to
7cd1c62
Compare
MichaelScofield
approved these changes
Feb 21, 2024
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Feb 21, 2024
* refactor: replace TableMetadataManager with TableNameManager * refactor: allocate table id in the procedure * refactor: refactor client logical of handling retries * feat(test_util): add TestCreateTableExprBuilder * feat(test_util): add MockDatanodeManager * feat(test_util): add new_ddl_context * feat(test_util): add build_raw_table_info_from_expr * feat(test_util): add MockDatanodeManager::new * feat(procedure): add downcast_output_ref to Status * test(create_table): add tests for CreateTableProcedure on_prepare * refactor(ddl): rename handle_operate_region_error to add_peer_context_if_need * test(create_table): add tests for CreateTableProcedure on_datanode_create_regions * test(create_table): add tests for CreateTableProcedure on_create_metadata * refactor(meta): use CreateTableExprBuilder * feat(create_table): ensure number of partitions is greater than 0 * refactor: rename to add_peer_context_if_needed * feat: add context for panic * refactor: simplify the should_retry * refactor: use Option<&T> instead of &Option<T> * refactor: move downcast_output_ref under cfg(test) * chore: fmt toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)
#3233