Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the receivers of merge tree components #3378

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 25, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Change the receivers of merge tree components' read methods to &self instead of &mut self so that Partition::read does not need to acquire write lock.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r requested a review from evenyag February 25, 2024 13:28
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 96.03960% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.29%. Comparing base (e481f07) to head (ae54a37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
- Coverage   85.67%   85.29%   -0.38%     
==========================================
  Files         893      893              
  Lines      147247   147207      -40     
==========================================
- Hits       126152   125566     -586     
- Misses      21095    21641     +546     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r force-pushed the refactor/merge-tree-read-mut branch from 4a2a3ae to ae54a37 Compare February 26, 2024 06:35
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Feb 26, 2024
Merged via the queue into GreptimeTeam:main with commit 8087822 Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants