Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move some costly methods in DataBuffer::read out of read lock #3406

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 28, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR moves the costly sort and dedup operation inside read_data_buffer_to_record_batch function out of the read lock of Partition.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 28, 2024
@v0y4g3r v0y4g3r requested a review from evenyag February 28, 2024 09:51
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (dc205a2) to head (97d3d45).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3406      +/-   ##
==========================================
- Coverage   85.07%   84.61%   -0.46%     
==========================================
  Files         889      889              
  Lines      146377   146280      -97     
==========================================
- Hits       124525   123778     -747     
- Misses      21852    22502     +650     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r requested a review from fengjiachun February 28, 2024 12:21
@evenyag evenyag added this pull request to the merge queue Feb 28, 2024
Merged via the queue into GreptimeTeam:main with commit 3413fc0 Feb 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants