-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support per table memtable options #3524
Merged
v0y4g3r
merged 15 commits into
GreptimeTeam:main
from
evenyag:feat/region-memtable-builder
Mar 19, 2024
Merged
feat: support per table memtable options #3524
v0y4g3r
merged 15 commits into
GreptimeTeam:main
from
evenyag:feat/region-memtable-builder
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/region-memtable-builder
branch
from
March 15, 2024 08:16
54ab0d8
to
4684242
Compare
Support deserializing memtable and compaction options from the option map
evenyag
force-pushed
the
feat/region-memtable-builder
branch
from
March 18, 2024 09:20
c26b108
to
90bb352
Compare
fengjiachun
reviewed
Mar 19, 2024
fengjiachun
approved these changes
Mar 19, 2024
v0y4g3r
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopefully we won't end up with |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR supports configuring memtable options for each table. It replaces the global memtable builder in the worker with a builder factory
MemtableBuilderProvider
.By default, all regions use the same
default_memtable_builder
. Ifmemtable.type
is specified in the region options, the provider will create a new memtable for the region. The memtable config in theMitoConfig
only applies to the default memtable.This PR changes the default global memtable to the old
time_series
memtable. It enables the new memtable in the metric engine by setting the memtable type explicitly.It also fixes an issue that the region uses the default value instead of returning an error if
compaction.twcs.max_active_window_files
isn't a valid integer.Checklist