-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get metasrv clusterinfo #3696
Merged
tisonkun
merged 10 commits into
GreptimeTeam:main
from
fengjiachun:feat/metasrv-clusterinfo
Apr 15, 2024
Merged
feat: get metasrv clusterinfo #3696
tisonkun
merged 10 commits into
GreptimeTeam:main
from
fengjiachun:feat/metasrv-clusterinfo
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
==========================================
- Coverage 85.57% 85.06% -0.51%
==========================================
Files 957 963 +6
Lines 159226 160622 +1396
==========================================
+ Hits 136258 136637 +379
- Misses 22968 23985 +1017 |
WenyXu
approved these changes
Apr 12, 2024
killme2008
reviewed
Apr 13, 2024
Co-authored-by: dennis zhuang <[email protected]>
Co-authored-by: dennis zhuang <[email protected]>
Signed-off-by: tison <[email protected]>
Co-authored-by: dennis zhuang <[email protected]>
tisonkun
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: tison <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
As the title said, provide a way to get the metasrvs info:
__metasrv_election_candidates/{address}
), and keeps it alive every 300 seconds. The key will be delete when no keep lease.Checklist