-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ChangeColumnType
for AlterKind
#3757
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3757 +/- ##
==========================================
- Coverage 85.51% 85.25% -0.27%
==========================================
Files 946 946
Lines 159555 160194 +639
==========================================
+ Hits 136447 136572 +125
- Misses 23108 23622 +514 |
I'll review this today if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the purpose of ModifyColumn
is solely to alter the column type, then ChangeType
would be a more apt name. @evenyag What do you think?
I prefer that each |
agree, then I will make changes later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work! Don't forget to change the PR title too.
ModifyColumn
for AlterKind
ChangeColumnType
for AlterKind
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3517
What's changed and what's your intention?
add
ChangeColumnType
toAlterKind
and validateChangeColumnType
, process the meta afterChangeColumnType
Tips: The
AlterKind::ChangeColumnType
part of mapping greptime-proto will be committed later (after the update of greptime-proto)Checklist