refactor: use secrecy SerectString to hold secrets option #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
tisonkun
commented
Apr 26, 2024
tisonkun
commented
Apr 26, 2024
tisonkun
commented
Apr 26, 2024
tisonkun
commented
Apr 26, 2024
tisonkun
commented
Apr 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
==========================================
- Coverage 85.63% 85.42% -0.22%
==========================================
Files 953 950 -3
Lines 162840 162950 +110
==========================================
- Hits 139447 139197 -250
- Misses 23393 23753 +360 |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Co-authored-by: LFC <[email protected]>
|
@MichaelScofield Comments addressed. |
Signed-off-by: tison <[email protected]>
MichaelScofield
approved these changes
Apr 28, 2024
fengjiachun
reviewed
Apr 28, 2024
Signed-off-by: tison <[email protected]>
|
@fengjiachun Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This closes #2144.
Checklist