-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support distributed EXPLAIN ANALYZE
#3908
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels good to me. Exquisite design
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3908 +/- ##
==========================================
+ Coverage 85.62% 85.65% +0.02%
==========================================
Files 952 961 +9
Lines 163611 164539 +928
==========================================
+ Hits 140093 140934 +841
- Misses 23518 23605 +87 |
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jeremyhi <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
ANALYZE
#2374What's changed and what's your intention?
Now
EXPLAIN ANALYZE
will work correctly under distributed mode. The format follows discussion here #2374 (comment)See
tests/cases/distributed/explain/analyze.result
for the example. Or here is one from my env:Checklist