feat: make flow distributed work&tests #4256
Conversation
WalkthroughThis update introduces significant enhancements and configurations for the flownode settings in both distributed and standalone modes. Key modifications include changes in the configuration files, updates to error handling, addition of gRPC server settings, frontend client integration, and refinements in metadata cache handling. These changes provide greater flexibility, improved error reporting, and enhanced performance in distributed environments. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Flownode
participant gRPC Server
participant FrontendClient
User->>Flownode: Start Flownode
Flownode->>gRPC Server: Setup connection
gRPC Server->>FrontendClient: Initialize FrontendClient
FrontendClient-->>gRPC Server: FrontendClient Ready
gRPC Server-->>Flownode: gRPC Server Ready
Flownode-->>User: Flownode Started Successfully
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
discord9
force-pushed
the
flow_fe_client
branch
2 times, most recently
from
05f5fa8 to
60f7b29
Compare
discord9
requested review from
zhongzc,
waynexia,
MichaelScofield and
a team
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (18)
- config/flownode.example.toml (1 hunks)
- src/cmd/Cargo.toml (1 hunks)
- src/cmd/src/error.rs (2 hunks)
- src/cmd/src/flownode.rs (5 hunks)
- src/flow/Cargo.toml (1 hunks)
- src/flow/src/adapter.rs (3 hunks)
- src/flow/src/fe_client.rs (1 hunks)
- src/flow/src/lib.rs (2 hunks)
- src/flow/src/server.rs (2 hunks)
- src/meta-srv/src/error.rs (3 hunks)
- src/meta-srv/src/handler/collect_stats_handler.rs (1 hunks)
- src/meta-srv/src/metasrv.rs (2 hunks)
- src/meta-srv/src/selector/common.rs (3 hunks)
- src/meta-srv/src/selector/round_robin.rs (2 hunks)
- src/meta-srv/src/table_meta_alloc.rs (2 hunks)
- src/operator/src/insert.rs (1 hunks)
- tests/cases/distributed/information_schema/cluster_info.result (2 hunks)
- tests/runner/src/env.rs (9 hunks)
Files skipped from review due to trivial changes (5)
- src/cmd/Cargo.toml
- src/flow/Cargo.toml
- src/meta-srv/src/handler/collect_stats_handler.rs
- src/meta-srv/src/selector/round_robin.rs
- src/operator/src/insert.rs
Additional comments not posted (56)
src/flow/src/lib.rs (2)
30-30: Confirm module addition.The
fe_clientmodule is correctly added.
40-40: Confirm re-export ofFrontendClient.The
FrontendClientis correctly re-exported.config/flownode.example.toml (12)
1-2: Confirm addition of mode setting.The
modesetting is correctly added.
4-6: Confirm addition of node identifier setting.The
node_idsetting is correctly added.
8-9: Confirm addition of frontend address setting.The
frontend_addrsetting is correctly added.
11-23: Confirm addition of gRPC server options.The gRPC server options are correctly added.
26-41: Confirm addition of metasrv client options and timeout settings.The metasrv client options and timeout settings are correctly added.
43-44: Confirm addition of TCP_NODELAY setting.The
tcp_nodelaysetting is correctly added.
46-53: Confirm addition of metadata cache configuration.The metadata cache configuration is correctly added.
55-61: Confirm addition of heartbeat options.The heartbeat options are correctly added.
63-70: Confirm addition of logging options.The logging options are correctly added.
72-77: Confirm addition of OTLP tracing options.The OTLP tracing options are correctly added.
79-87: Confirm addition of logging tracing sample ratio.The logging tracing sample ratio is correctly added.
88-92: Confirm addition of tracing options.The tracing options are correctly added.
src/meta-srv/src/table_meta_alloc.rs (2)
25-25: Confirm addition of imports.The imports for
SelectTargetandSelectorRefare correctly added.
67-70: Confirm use ofSelectTarget::Datanodein error handling.The
SelectTarget::Datanodeis correctly used in error handling.src/flow/src/fe_client.rs (9)
1-13: Confirm license header.The license header is correctly added.
15-15: Confirm module documentation.The module documentation is correctly added.
17-29: Confirm necessary imports.The necessary imports are correctly added.
32-35: ConfirmFrontendClientstruct definition.The
FrontendClientstruct is correctly defined.
37-43: ConfirmFrontendClientconstructor.The
FrontendClientconstructor is correctly implemented.
45-60: Confirmto_rpc_requestfunction.The
to_rpc_requestfunction is correctly implemented.
62-65: Confirmfrom_rpc_errorfunction.The
from_rpc_errorfunction is correctly implemented.
67-76: Confirmresp_to_outputfunction.The
resp_to_outputfunction is correctly implemented.
78-108: Confirm implementation ofFrontendInvokerforFrontendClient.The implementation of
FrontendInvokerforFrontendClientis correctly done.tests/cases/distributed/information_schema/cluster_info.result (2)
28-28: Ensure Consistency of Output Format.The added line includes multiple peer types with their respective addresses and details. Verify that the format matches the expected output and that all necessary fields are included.
Ensure that the output format is consistent with other similar outputs and that all necessary fields are correctly populated.
58-58: Ensure Consistency of Output Format.The added line includes multiple peer types with their respective addresses and details. Verify that the format matches the expected output and that all necessary fields are included.
Ensure that the output format is consistent with other similar outputs and that all necessary fields are correctly populated.
src/meta-srv/src/selector/common.rs (3)
23-23: Import Statement Added.The
SelectTargetimport is added. Ensure that this import is necessary and used correctly within the file.The import statement is necessary for the modified error handling.
38-41: Updated Error Handling: NoEnoughAvailableNodeSnafu.The error handling now uses
NoEnoughAvailableNodeSnafuwithSelectTarget::Datanode. Ensure that this change is consistent with the rest of the codebase.The updated error handling is consistent with the new naming convention and usage of
SelectTarget.
57-60: Updated Error Handling: NoEnoughAvailableNodeSnafu.The error handling now uses
NoEnoughAvailableNodeSnafuwithSelectTarget::Datanode. Ensure that this change is consistent with the rest of the codebase.The updated error handling is consistent with the new naming convention and usage of
SelectTarget.src/flow/src/server.rs (1)
124-127: Added Compression Handling.The
FlownodeServernow handles compressed data using gzip and zstd encoding. Ensure that the compression handling is correctly implemented and consistent with the rest of the code.The compression handling is correctly implemented and consistent with the rest of the code.
src/cmd/src/flownode.rs (7)
34-34: Import Statement Added.The
Endpointimport is added. Ensure that this import is necessary and used correctly within the file.The import statement is necessary for the new frontend connection setup.
39-39: Import Statement Added.The
TonicTransportSnafuimport is added. Ensure that this import is necessary and used correctly within the file.The import statement is necessary for the new error handling.
123-142: Added Fields to StartCommand Struct.The
StartCommandstruct now includes additional fields fornode_id,rpc_addr,rpc_hostname,metasrv_addrs,frontend_addr,config_file, andenv_prefix. Ensure that these fields are necessary and used correctly within the struct.The added fields are necessary for the new functionality and are used correctly within the struct.
189-191: Set Frontend Address in merge_with_cli_options.The
merge_with_cli_optionsmethod now sets thefrontend_addrfield. Ensure that this change is necessary and correctly implemented.The change is necessary for setting the frontend address and is correctly implemented.
231-232: Ensure Frontend Address is Provided.The
buildmethod now ensures that thefrontend_addris provided. Ensure that this change is necessary and correctly implemented.The change is necessary for ensuring the frontend address is provided and is correctly implemented.
235-237: Optional Cluster ID Handling.The
buildmethod now handles an optionalcluster_id. Ensure that this change is correctly implemented.The change is correctly implemented for handling an optional
cluster_id.
319-334: Set Up Frontend Connection.The
buildmethod now sets up a connection to the frontend server using Tonic transport. Ensure that this change is correctly implemented.The change is correctly implemented for setting up the frontend connection.
src/cmd/src/error.rs (2)
350-357: Addition of a new error variantTonicTransport.The new error variant
TonicTransportis added to handle errors related to Tonic transport. This variant includes a location, the Tonic transport error, and an optional message. The implementation is correct and follows Rust's error handling best practices.
417-417: Handling ofTonicTransportinErrorExtimplementation.The new error variant
TonicTransportis correctly mapped to theStatusCode::Internalstatus code. This ensures that Tonic transport errors are appropriately categorized as internal server errors.src/meta-srv/src/metasrv.rs (1)
252-259: Implementation of theDisplaytrait forSelectTarget.The
Displaytrait is correctly implemented for theSelectTargetenum. This allows for user-friendly string representations of the enum variants, which is useful for logging and debugging.tests/runner/src/env.rs (9)
118-118: Addition offlownode_processfield toGreptimeDBstruct.The
flownode_processfield is added to manage the flownode process. This change is consistent with the other process management fields and helps in managing the flownode process.
145-146: Starting the flownode process in distributed mode.The flownode process is correctly started in the
start_distributedmethod. This ensures that the flownode process is included in the distributed setup.
156-156: Addition offlownode_processfield toGreptimeDBstruct.The
flownode_processfield is added to manage the flownode process in thestart_distributedmethod. This change is consistent with the other process management fields and helps in managing the flownode process.
173-173: Addition offlownode_processfield toGreptimeDBstruct.The
flownode_processfield is added to manage the flownode process in theconnect_dbmethod. This change is consistent with the other process management fields and helps in managing the flownode process.
200-201: Log file naming for flownode process.The log file for the flownode process is correctly named and managed in the
start_servermethod. This ensures that logs for the flownode process are properly handled.
221-221: Starting the flownode process.The arguments for starting the flownode process are correctly set up in the
start_servermethod. This ensures that the flownode process is started with the correct configuration.
318-332: Addition offlownode_start_argsmethod.The
flownode_start_argsmethod is correctly implemented to generate the arguments needed to start the flownode process. This method ensures that the flownode process is started with the correct configuration.
448-448: Addition offlownode_processfield toGreptimeDBstruct.The
flownode_processfield is added to manage the flownode process in theGreptimeDBstruct. This change is consistent with the other process management fields and helps in managing the flownode process.
544-547: Stopping the flownode process.The flownode process is correctly stopped in the
stopmethod. This ensures that the flownode process is properly managed and terminated.src/flow/src/adapter.rs (3)
87-87: Addition offrontend_addrfield toFlownodeOptionsstruct.The
frontend_addrfield is added to theFlownodeOptionsstruct to specify the address of the frontend. This change is consistent with the other configuration options and helps in setting up the flownode.
101-101: Initialization offrontend_addrfield inFlownodeOptionsstruct.The
frontend_addrfield is correctly initialized toNonein theDefaultimplementation of theFlownodeOptionsstruct. This ensures that the field is properly handled when the struct is created with default values.
138-138: Modification ofset_frontend_invokermethod signature.The
set_frontend_invokermethod signature is modified to accept a boxedFrontendInvoker. This change is consistent with the usage of theFrontendInvokerin theFlowWorkerManagerstruct and ensures that the invoker is properly handled.src/meta-srv/src/error.rs (3)
29-29: Import Approved:SelectTargetThe import of
SelectTargetis necessary for the new error variantNoEnoughAvailableNode.
179-189: Addition Approved:NoEnoughAvailableNodeError VariantThe
NoEnoughAvailableNodeerror variant is correctly defined with relevant fields.
901-901: Integration Approved:NoEnoughAvailableNodeinstatus_codeMethodThe
NoEnoughAvailableNodeerror variant is appropriately mapped toStatusCode::Internal.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4256 +/- ##
==========================================
- Coverage 85.25% 84.94% -0.31%
==========================================
Files 1058 1059 +1
Lines 186971 187054 +83
==========================================
- Hits 159404 158898 -506
- Misses 27567 28156 +589 |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
config/config-docs-template.md (1)
29-31: Fix trailing newline issue.Ensure the file ends with a single newline character to adhere to Markdownlint guidelines.
- {{ toml2docs "./flownode.example.toml"}} + {{ toml2docs "./flownode.example.toml"}} +Tools
Markdownlint
31-31: null
Files should end with a single newline character(MD047, single-trailing-newline)
config/config.md (3)
441-478: Fix grammatical issues and trailing blank lines.
- Grammatical Fix: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
- Complete Sentence: Ensure the log level description forms a complete sentence.
- Trailing Blank Lines: Remove multiple consecutive blank lines to adhere to Markdownlint guidelines.
- | `frontend_addr` | String | `http://127.0.0.1:4001` | Frontend grpc address. Used by flownode to write result back to frontend. | + | `frontend_addr` | String | `http://127.0.0.1:4001` | Frontend gRPC address. Used by flownode to write results back to the frontend. | - | `logging.level` | String | `None` | The log level. Can be `info`/`debug`/`warn`/`error`. | + | `logging.level` | String | `None` | The log level, which can be `info`, `debug`, `warn`, or `error`. | - -Tools
LanguageTool
[grammar] ~449-~449: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
[style] ~471-~471: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
Markdownlint
442-442: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
[!TIP]
Codebase VerificationUpdate default HTTP address for distributed mode.
The default HTTP address for the
Frontendin distributed mode has not been consistently updated across the documentation. Please update the following occurrences of the old address127.0.0.1:4000to the new address:
config/config.md:
- Line containing
| http.addr | String | 127.0.0.1:4000 | The address to bind the HTTP server. |- Lines containing
| export_metrics.remote_write.url | String | "" | The url the metrics send to. The url example can be: http://127.0.0.1:4000/v1/prometheus/write?db=information_schema.Analysis chain
Line range hint
163-173:
Update default HTTP address for distributed mode.The default HTTP address for the
Frontendin distributed mode has been updated. Ensure that this change is consistent with other parts of the documentation.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the updated HTTP address for the Frontend is consistent across the documentation. # Test: Search for the old default HTTP address. Expect: No occurrences of the old address. rg --type markdown $'127.0.0.1:4000'Length of output: 907
[!TIP]
Codebase VerificationInconsistent default HTTP address for Datanode in distributed mode
The documentation contains multiple different default HTTP addresses for the Datanode (
127.0.0.1:4000,127.0.0.1:6000, and127.0.0.1:5000). Please review and ensure that the default HTTP address for the Datanode in distributed mode is consistent across all occurrences.
config/config.md:
http.addr| String |127.0.0.1:4000http.addr| String |127.0.0.1:6000http.addr| String |127.0.0.1:5000Analysis chain
Line range hint
310-339:
Update default HTTP address forDatanodein distributed mode.The default HTTP address for the
Datanodein distributed mode has been updated. Ensure that this change is consistent with other parts of the documentation.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the updated HTTP address for the Datanode is consistent across the documentation. # Test: Search for the old default HTTP address. Expect: No occurrences of the old address. rg --type markdown $'127.0.0.1:4000'Length of output: 907
Script:
#!/bin/bash # Description: Verify if the new default HTTP address for the Datanode is mentioned in the documentation. # Test: Search for the new default HTTP address pattern. Expect: Occurrences of the new address. rg --type markdown '127.0.0.1:'Length of output: 2399
Script:
#!/bin/bash # Description: Verify if the default HTTP address for the Datanode in distributed mode is mentioned correctly. # Test: Search for occurrences of `http.addr` in the context of Datanode in distributed mode. rg --type markdown 'http.addr'Length of output: 296
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- config/config-docs-template.md (2 hunks)
- config/config.md (6 hunks)
- config/flownode.example.toml (1 hunks)
- src/flow/src/fe_client.rs (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- config/flownode.example.toml
- src/flow/src/fe_client.rs
Additional context used
Markdownlint
config/config-docs-template.md
31-31: null
Files should end with a single newline character(MD047, single-trailing-newline)
config/config.md
442-442: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
LanguageTool
config/config.md
[grammar] ~449-~449: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
[style] ~471-~471: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
Additional comments not posted (2)
config/config-docs-template.md (1)
3-9: Ensure correct logical placement of the new section.The new
Flownodesection is logically placed under theDistributed Modeconfigurations. The structure looks good.config/config.md (1)
3-9: Ensure correct logical placement of the new section.The new
Flownodesection is logically placed under theDistributed Modeconfigurations. The structure looks good.
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
config/config.md (1)
439-440: Remove extra blank line.There are multiple consecutive blank lines. Remove the extra blank line for cleaner formatting.
-Tools
Markdownlint
440-440: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- config/config.md (2 hunks)
Additional context used
LanguageTool
config/config.md
[grammar] ~447-~447: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
[style] ~469-~469: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
Markdownlint
config/config.md
440-440: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Additional comments not posted (2)
config/config.md (2)
441-476: New sectionFlownodeconfiguration looks good!The new configuration options for
Flownodeare well-documented and comprehensive.Tools
LanguageTool
[grammar] ~447-~447: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
[style] ~469-~469: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
3-9: Table of contents update looks good!The table of contents has been correctly updated to include the new
Flownodesection.
feat: Frontend Client feat: set frontend invoker for flownode feat: set frontend invoker for flownode chore: test script WIP: test flow distributed feat: hard coded demo docs: flownode example toml feat: add flownode support in runner docs: comments for node chore: after rebase docs: add a todo tests: move flow tests to common fix: flownode sqlness dist test chore: per review docs: make fix: make doc
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
config/config-docs-template.md (1)
3-9: Add an entry for Flownode in the table of contents.The addition of the Flownode section in the distributed mode should be reflected in the table of contents for completeness.
- - [Distributed Mode](#distributed-mode) - - [Frontend](#frontend) - - [Metasrv](#metasrv) - - [Datanode](#datanode) + - [Distributed Mode](#distributed-mode) + - [Frontend](#frontend) + - [Metasrv](#metasrv) + - [Datanode](#datanode) + - [Flownode](#flownode)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (20)
- config/config-docs-template.md (2 hunks)
- config/config.md (2 hunks)
- config/flownode.example.toml (1 hunks)
- src/cmd/Cargo.toml (1 hunks)
- src/cmd/src/error.rs (2 hunks)
- src/cmd/src/flownode.rs (5 hunks)
- src/flow/Cargo.toml (1 hunks)
- src/flow/src/adapter.rs (3 hunks)
- src/flow/src/fe_client.rs (1 hunks)
- src/flow/src/lib.rs (2 hunks)
- src/flow/src/server.rs (2 hunks)
- src/meta-srv/src/error.rs (3 hunks)
- src/meta-srv/src/handler/collect_stats_handler.rs (1 hunks)
- src/meta-srv/src/metasrv.rs (2 hunks)
- src/meta-srv/src/selector/common.rs (3 hunks)
- src/meta-srv/src/selector/round_robin.rs (2 hunks)
- src/meta-srv/src/table_meta_alloc.rs (2 hunks)
- src/operator/src/insert.rs (1 hunks)
- tests/cases/distributed/information_schema/cluster_info.result (2 hunks)
- tests/runner/src/env.rs (9 hunks)
Files skipped from review as they are similar to previous changes (17)
- config/flownode.example.toml
- src/cmd/Cargo.toml
- src/cmd/src/error.rs
- src/cmd/src/flownode.rs
- src/flow/Cargo.toml
- src/flow/src/adapter.rs
- src/flow/src/fe_client.rs
- src/flow/src/server.rs
- src/meta-srv/src/error.rs
- src/meta-srv/src/handler/collect_stats_handler.rs
- src/meta-srv/src/metasrv.rs
- src/meta-srv/src/selector/common.rs
- src/meta-srv/src/selector/round_robin.rs
- src/meta-srv/src/table_meta_alloc.rs
- src/operator/src/insert.rs
- tests/cases/distributed/information_schema/cluster_info.result
- tests/runner/src/env.rs
Additional context used
Markdownlint
config/config-docs-template.md
31-31: null
Files should end with a single newline character(MD047, single-trailing-newline)
config/config.md
440-440: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
LanguageTool
config/config.md
[grammar] ~447-~447: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
[style] ~469-~469: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
Additional comments not posted (4)
src/flow/src/lib.rs (2)
30-30: LGTM!The addition of the
fe_clientmodule is consistent with the rest of the file.
40-40: LGTM!The export of
FrontendClientis consistent with the rest of the file.config/config.md (2)
441-447: Fix grammatical issue.The word 'frontend' is not correct in this context. Use 'front end' instead.
- Used by flownode to write result back to frontend. + Used by flownode to write result back to the front end.Tools
LanguageTool
[grammar] ~447-~447: The word ‘frontend’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: .... Used by flownode to write result back to frontend. | |grpc| -- | -- | The gRPC server...(VB_TO_NN_DT)
469-469: Incomplete sentence.To form a complete sentence, be sure to include a subject.
- The log level. Can be `info`/`debug`/`warn`/`error`. + The log level. It can be `info`/`debug`/`warn`/`error`.Tools
LanguageTool
[style] ~469-~469: To form a complete sentence, be sure to include a subject.
Context: ...vel| String |None| The log level. Can beinfo/debug/warn/error. | |...(MISSING_IT_THERE)
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
preq: #4254
What's changed and what's your intention?
make flownode dist start work
FrontendClientfor flownode to connect to frontend for writing back resultsChecklist
Summary by CodeRabbit
New Features
Enhancements
Documentation
Tests