Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): flush_flow function #4416

Merged
merged 23 commits into from
Jul 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: flush lock write then drop
  • Loading branch information
discord9 committed Jul 26, 2024
commit 66b024c0fdfbbc8ae23e0a98f7e066abf6bc1cf5
3 changes: 2 additions & 1 deletion src/flow/src/adapter/flownode_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ impl Flownode for FlowWorkerManager {
// TODO(discord9): impl individual flush
debug!("Starting to flush flow_id={:?}", flow_id);
// lock to make sure writes before flush are written to flow
let _flush_lock = self.flush_lock.write().await;
// and immediately drop to prevent following writes to be blocked
drop(self.flush_lock.write().await);
let flushed_input_rows = self
.node_context
.read()
Expand Down