-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement postgres kvbackend #4421
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
475b628
to
5d7b912
Compare
5d7b912
to
408d9a1
Compare
883ac2d
to
4c2c67f
Compare
4c2c67f
to
3f1c8db
Compare
e264178
to
ca35aa2
Compare
f16b04a
to
1279104
Compare
@lyang24 Hi, there are some CI failures, could you check them? |
1279104
to
b850877
Compare
Yes, ci is green now |
b850877
to
a4a696e
Compare
@lyang24 Is it ready to review? If it is, I'd like to do it. |
98c9df7
to
8b1c4d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM.
1aafeaa
to
8d8334a
Compare
8d8334a
to
74a945c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@lyang24 Thanks a lot. It's a great work! |
@lyang24 Would like to add the sample configurations into https://github.com/GreptimeTeam/greptimedb/blob/main/config/metasrv.example.toml and describe them in the doc https://docs.greptime.com/user-guide/operations/configuration#metasrv-only-configuration ? |
yes will do |
This commit implement a postgres backend to persist metasrv's data. A new enum
BackendImpl
with default to etcd was added toMetasrvOptions
to activate postgres backend we could setBackendImpl
to postgres and setstore_addrs
to postgres url.I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
!!! DO NOT LEAVE THIS BLOCK EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist