feat: remove dedicated runtime for grpc, mysql and pg protocols

[waynexia]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Refine runtime related usages.

Major changes:

• remove dedicated runtime for gRPC, MySQL and Postgres
• replace read, write, bg runtimes with the new unified one global_runtime
• add a new compact_runtime for compaction only to limit its max CPU usage. This is a simple workaround at present.

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 84.67742% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (53fc14a) to head (30048aa).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4436      +/-   ##
==========================================
- Coverage   84.88%   84.60%   -0.28%     
==========================================
  Files        1081     1081              
  Lines      192961   193003      +42     
==========================================
- Hits       163791   163290     -501     
- Misses      29170    29713     +543     

[zhongzc]

rest LGTM

[sunng87]

Actually this is a breaking change. It changes how we configure and tune the server. We'd better including this in next minor release instead of patch release.

[waynexia]

Actually this is a breaking change. It changes how we configure and tune the server. We'd better including this in next minor release instead of patch release.

I've tested this change won't fail the server start progress. Only the old config won't take effect so I didn't categorize it as breaking change.

[evenyag]

Do we need to run the alive keeper in the heartbeat runtime? The region alive keeper may be related to the heartbeat task.

[evenyag]

Still timeout
https://github.com/GreptimeTeam/greptimedb/actions/runs/10146099115/job/28053577040?pr=4436

[WenyXu]

Still timeout https://github.com/GreptimeTeam/greptimedb/actions/runs/10146099115/job/28053577040?pr=4436

I updated the runtime config for tests. By default, each pod will be allocated up to 1 core CPU (which will lead the default global_rt_size to be 1). However, it's problematic to set the global runtime size to 1 (e.g., deadlock).

[evenyag]

I updated the runtime config for tests. By default, each pod will be allocated up to 1 core CPU (which will lead the default global_rt_size to be 1). However, it's problematic to set the global runtime size to 1 (e.g., deadlock).

I found the table is flushing:

2024-07-29T14:29:49.385378397Z stdout F 2024-07-29T14:29:49.385189Z  INFO operator::request: Handle table manual flush request: FlushTableRequest { catalog_name: "greptime", schema_name: "public", table_name: "quod" }

The admin function may be the cause. We try to block inside the async runtime and hang the whole runtime.

greptimedb/src/common/macro/src/admin_fn.rs

Lines 230 to 248 in 53fc14a

	if columns_num == 0 {
	let result = common_runtime::block_on_read(async move {
	#fn_name(handler, query_ctx, &[]).await
	})?;
	builder.push_value_ref(result.as_value_ref());
	} else {
	for i in 0..rows_num {
	let args: Vec<_> = columns.iter()
	.map(|vector| vector.get_ref(i))
	.collect();
	let result = common_runtime::block_on_read(async move {
	#fn_name(handler, query_ctx, &args).await
	})?;
	builder.push_value_ref(result.as_value_ref());
	}
	}