-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement the Buf to avoid extra memory allocation #4585
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @ozewr !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @ozewr !
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4585 +/- ##
==========================================
- Coverage 84.90% 84.63% -0.27%
==========================================
Files 1096 1096
Lines 196649 196655 +6
==========================================
- Hits 166963 166448 -515
- Misses 29686 30207 +521 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Weny Xu <[email protected]>
…m#4585) * feat: Implement the Buf to avoid extra memory allocation * fmt toml * fmt code * mv entry.into_buffer to raw_entry_buffer * less reuse opendal * remove todo GreptimeTeam#4065 * Update src/mito2/src/wal/entry_reader.rs Co-authored-by: Weny Xu <[email protected]> * fmt code --------- Co-authored-by: ozewr <[email protected]> Co-authored-by: Weny Xu <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #4065
What's changed and what's your intention?
Impl new function
into_buffer
for Entry in/home/wr/workspace/greptimedb/src/store-api/src/logstore/entry.rs
.This function returns a
buffer
that comes from theopendal
library, but is reused in theobject-store
.Use
into_buffer
to avoid extra memory allocation in filesrc/mito2/src/wal/entry_reader.rs
.Checklist