-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collect filters metrics for scanners #4591
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes enhance the functionality of the scanning and reading processes within the project, focusing on improved metrics collection and management. Key updates include the introduction of a compaction mode for scanning, refined metric structures for better organization, and enhancements to the handling of filtering metrics. These modifications aim to provide more insightful performance data, making the system more robust and efficient during data operations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SeqScan
participant ReaderMetrics
User->>SeqScan: Start scan
SeqScan->>SeqScan: with_compaction()
SeqScan->>ReaderMetrics: Initialize metrics
SeqScan->>SeqScan: Perform scan
SeqScan->>ReaderMetrics: Collect metrics
ReaderMetrics-->>SeqScan: Return metrics
SeqScan-->>User: Complete scan with metrics
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@coderabbitai summary |
Actions performedSummary regeneration triggered. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4591 +/- ##
==========================================
- Coverage 84.90% 84.64% -0.26%
==========================================
Files 1096 1096
Lines 196635 196655 +20
==========================================
- Hits 166949 166464 -485
- Misses 29686 30191 +505 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: collect filter metrics * refactor: reuse ReaderFilterMetrics * feat: record read rows from parquet by type * feat: unordered scan observe rows also fix read type * chore: rename label
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds
ReaderFilterMetrics
and collects the metrics forSeqScan
andUnorderedScan
.It also observes read row counts for scanners and compaction.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation