-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mito2): reduce duplicate IndexOutput struct #4592
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
- Coverage 84.88% 84.65% -0.24%
==========================================
Files 1094 1096 +2
Lines 196306 196607 +301
==========================================
- Hits 166639 166442 -197
- Misses 29667 30165 +498 |
Head branch was pushed to by a user without write access
Thanks ❤️ |
* refactor(mito2): reduce duplicate IndexOutput struct * docs(mito2): add index output note
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4586
What's changed and what's your intention?
IndexOutput
struct.IndexBaseOutput
toInvertedIndexOutput
andFulltextIndexOutput
.Checklist