feat: refactoring LruCacheLayer with list_with_metakey and concurrent_stat_in_list

[ozewr]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3059

What's changed and what's your intention?

• build Operator from file_cache in recover_cache function
• use list_with_metakey and concurrent_stat_in_list instead of list

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ozewr]

Is it Ok? I used clone . But if I don't use clone ,I cannot use list_with_metakey and concurrent_stat_in_list. Perhaps not do ant change would be better?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (a3b8d2f) to head (b5107a9).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4596      +/-   ##
==========================================
- Coverage   84.93%   84.66%   -0.28%     
==========================================
  Files        1096     1096              
  Lines      196750   196751       +1     
==========================================
- Hits       167110   166571     -539     
- Misses      29640    30180     +540     

[WenyXu]

Is it Ok? I used clone . But if I don't use clone ,I cannot use list_with_metakey and concurrent_stat_in_list. Perhaps not do ant change would be better?

Hi @ozewr, we can retrieve the content lenght in list_with_metakey too.

let entries: Vec<Entry> = op
  .list_with("dir")
  .metakey(Metakey::ContentLength | Metakey::ContentType).await?;

then we can avoid to call the stat function:

let size = {
    let stat = self.file_cache.stat(read_key, OpStat::default()).await?;
    stat.into_metadata().content_length()
};

[WenyXu]

Rest LGTM

[evenyag]

Others LGTM

[WenyXu]

some nitpicks:

• Always make sure name is unambiguity