-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports name in object storage config #4630
feat: supports name in object storage config #4630
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47a48df
to
746f30e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
==========================================
- Coverage 84.84% 84.61% -0.23%
==========================================
Files 1105 1105
Lines 199056 199153 +97
==========================================
- Hits 168886 168521 -365
- Misses 30170 30632 +462 |
* feat: supports name in object storage config * fix: integration test * fix: integration test * fix: update sample config * fix: config api test
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4444
What's changed and what's your intention?
Main changes:
name
field to s3, oss, gcs and azblob configurations.name
field to find the provider.name
field is empty.Checklist