feat: initialize partition range from ScanInput #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4635 +/- ##
==========================================
- Coverage 84.89% 84.59% -0.31%
==========================================
Files 1101 1105 +4
Lines 197288 199051 +1763
==========================================
+ Hits 167496 168384 +888
- Misses 29792 30667 +875 |
evenyag
approved these changes
Aug 29, 2024
Signed-off-by: Ruihang Xia <[email protected]>
Co-authored-by: jeremyhi <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
CookiePieWw
pushed a commit
to CookiePieWw/greptimedb
that referenced
this pull request
Sep 17, 2024
* feat: initialize partition range from ScanInput Signed-off-by: Ruihang Xia <[email protected]> * use num_rows instead Signed-off-by: Ruihang Xia <[email protected]> * add todo Signed-off-by: Ruihang Xia <[email protected]> * setup unordered scan Signed-off-by: Ruihang Xia <[email protected]> * Update src/mito2/src/read/scan_region.rs Co-authored-by: jeremyhi <[email protected]> * leave unordered scan unchanged Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]> Co-authored-by: jeremyhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Initialize
PartitionRanges fromScanInputfor planner. It only contains a rough time range and number of rows at present.The next step is to modify the corresponding logic about initializing
StreamContext.This patch also fixes the problem that
RegionScanExecalways generates only 1 partition.Checklist