-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use 'target' for 'actions-rust-lang/setup-rust-toolchain' to fix cross build failed #4661
Conversation
… cross build failed
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Early access features: disabledWe are currently testing the following features in early access:
Note:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4661 +/- ##
==========================================
- Coverage 84.84% 84.58% -0.27%
==========================================
Files 1105 1105
Lines 199056 199056
==========================================
- Hits 168893 168362 -531
- Misses 30163 30694 +531 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… cross build failed (GreptimeTeam#4661)
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Since 0b102ef changes the rust setup action from
dtolnay/rust-toolchain
toactions-rust-lang/setup-rust-toolchain
, we need to resolve some arguments incompatible:dtolnay/rust-toolchain
support bothtarget
andtargets
: https://github.com/dtolnay/rust-toolchain/blob/master/action.yml#L12-L17;actions-rust-lang/setup-rust-toolchain
only supporttarget
: https://github.com/actions-rust-lang/setup-rust-toolchain/blob/main/action.yml#L18Unfortunately, we use
targets
in the original release action.Checklist