-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: sqlness upgrade compatibility tests #5126
test: sqlness upgrade compatibility tests #5126
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
==========================================
- Coverage 84.04% 83.78% -0.27%
==========================================
Files 1168 1172 +4
Lines 217620 218237 +617
==========================================
- Hits 182896 182842 -54
- Misses 34724 35395 +671 |
6675f0f
to
34915b8
Compare
3c77188
to
462dd4e
Compare
* feat: simple version switch * chore: remove debug print * chore: add common folder * tests: add drop table * feat: pull versioned binary * chore: don't use native-tls * chore: rm outdated docs * chore: new line * fix: save old bin dir * fix: switch version restart all node * feat: use etcd * fix: wait for election * fix: normal sqlness * refactor: hashmap for bin dir * test: past 3 major version compat crate table * refactor: allow using without setup etcd
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add a way to test inter-version compatibility in sqlness
Please explain IN DETAIL what the changes are in this PR and why they are needed:
-- SQLNESS ARG version=v0.x.x
which will restart greptime from given binary in a directoryversion=xxx
, default to pull, but can set to not pull and manually download it.to playaround with this test, run:
(make sure to use absolute path for case dir, the
-c
option, can also add--preserve-state
to look into/tmp/sqlness*****/greptime-sqlness-standalone.log
to make sure it actually switched version, note this require docker and create aetcd
docker container for metadata storage during testing)Summary
Basically just restart greptime using another binary
Well this can't currently test http api, but I intended to add ability to invoke bash in sqlness tests,
so one can just call
curl
in sqlness testsChecklist