Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sqlness upgrade compatibility tests #5126

Merged
merged 16 commits into from
Dec 17, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Dec 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add a way to test inter-version compatibility in sqlness

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • add a -- SQLNESS ARG version=v0.x.x which will restart greptime from given binary in a directory
  • add a simple poc sqlness test, to run those tests
  • add ability to pull different version binary from github release when encounter version=xxx, default to pull, but can set to not pull and manually download it.
  • more sqlness tests can be added later in separate PR to prevent bloat
  • add ability to setup a standalone etcd for metasrv metadata storage so restarting metasrv wouldn't clean up metadata

to playaround with this test, run:

cargo sqlness -c $(pwd)/tests/upgrade-compat --store-addrs "0.0.0.0:2379" --setup-etcd 

(make sure to use absolute path for case dir, the -c option, can also add --preserve-state to look into /tmp/sqlness*****/greptime-sqlness-standalone.log to make sure it actually switched version, note this require docker and create a etcd docker container for metadata storage during testing)

Summary

  • How does this PR work? Need a brief introduction for the changed logic (optional)
    Basically just restart greptime using another binary
  • Describe any limitations of the current code (optional)
    Well this can't currently test http api, but I intended to add ability to invoke bash in sqlness tests,
    so one can just call curl in sqlness tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@discord9 discord9 requested a review from a team as a code owner December 9, 2024 09:20
Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Dec 9, 2024
@discord9 discord9 changed the title tests: sqlness upgrade compatiblity tests test: sqlness upgrade compatiblity tests Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (03a2832) to head (3ebdb23).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5126      +/-   ##
==========================================
- Coverage   84.04%   83.78%   -0.27%     
==========================================
  Files        1168     1172       +4     
  Lines      217620   218237     +617     
==========================================
- Hits       182896   182842      -54     
- Misses      34724    35395     +671     

@discord9 discord9 force-pushed the sqlness_version_cmd branch from 3c77188 to 462dd4e Compare December 10, 2024 07:22
@discord9 discord9 requested review from waynexia and removed request for fengjiachun, v0y4g3r and evenyag December 11, 2024 06:50
@discord9 discord9 changed the title test: sqlness upgrade compatiblity tests test: sqlness upgrade compatibility tests Dec 12, 2024
@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 17, 2024
Merged via the queue into GreptimeTeam:main with commit 421088a Dec 17, 2024
36 checks passed
evenyag pushed a commit that referenced this pull request Dec 20, 2024
* feat: simple version switch

* chore: remove debug print

* chore: add common folder

* tests: add drop table

* feat: pull versioned binary

* chore: don't use native-tls

* chore: rm outdated docs

* chore: new line

* fix: save old bin dir

* fix: switch version restart all node

* feat: use etcd

* fix: wait for election

* fix: normal sqlness

* refactor: hashmap for bin dir

* test: past 3 major version compat crate table

* refactor: allow using without setup etcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants