-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prefetch support to InvertedIndexFooterReader
for reduced I/O time
#5146
feat: add prefetch support to InvertedIndexFooterReader
for reduced I/O time
#5146
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
6a0c944
to
c742eda
Compare
c742eda
to
0a6bfbd
Compare
InvertedIndexBlobReader
InvertedIndeFooterReader
InvertedIndeFooterReader
InvertedIndeFooterReader
for reduced I/O time
InvertedIndeFooterReader
for reduced I/O timeInvertedIndexFooterReader
for reduced I/O time
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
- Coverage 84.05% 83.80% -0.25%
==========================================
Files 1169 1169
Lines 217737 217789 +52
==========================================
- Hits 183015 182517 -498
- Misses 34722 35272 +550 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… I/O time (#5146) * feat: add prefetch support to `InvertedIndeFooterReader` * chore: correct struct name * chore: apply suggestions from CR
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add prefetch support to
InvertedIndexFooterReader
, and set the default prefetch size to 1KiB. To reduce the inefficiency of discrete small S3 IO operations.Checklist