-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upload .pdb files too for better windows debug #5224
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
==========================================
- Coverage 84.10% 83.86% -0.25%
==========================================
Files 1192 1192
Lines 220875 220875
==========================================
- Hits 185769 185238 -531
- Misses 35106 35637 +531 |
After #5228 merged, we should change - name: Upload artifacts
uses: ./.github/actions/upload-artifacts
with:
artifacts-dir: ${{ inputs.artifacts-dir }}
target-files: target/${{ inputs.arch }}/${{ inputs.cargo-profile }}/greptime,target/${{ inputs.arch }}/${{ inputs.cargo-profile }}/greptime.pdb
version: ${{ inputs.version }} |
8475bdb
to
334dbee
Compare
Verified can pack pdb: https://github.com/GreptimeTeam/greptimedb/actions/runs/12489005286/artifacts/2360710349 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
.pdb
file is the windows debug info file(unlike linux is in a separate file)and cargo copy it to target directory if compile on windows(see this and cargo's source code)
Please explain IN DETAIL what the changes are in this PR and why they are needed:
PR Checklist
Please convert it to a draft if some of the following conditions are not met.