feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. #5231

zyy17 · 2024-12-24T15:45:29Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce the Limiter in frontend to limit the requests by in-flight write bytes size.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.
API changes are backward compatible.
Schema or data changes are backward compatible.

coderabbitai · 2024-12-24T15:45:38Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-25T05:40:00Z

Codecov Report

Attention: Patch coverage is 62.35741% with 99 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (a23f269) to head (f4cf082).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5231      +/-   ##
==========================================
- Coverage   84.11%   83.84%   -0.27%     
==========================================
  Files        1192     1193       +1     
  Lines      220856   221117     +261     
==========================================
- Hits       185762   185395     -367     
- Misses      35094    35722     +628

waynexia

Can we hold the frontend from receiving new requests instead of rejecting them?

waynexia · 2024-12-25T06:24:38Z

src/frontend/src/limiter.rs

+        self.in_flight_write_bytes.load(Ordering::Relaxed)
+    }
+
+    fn insert_requests_data_size(&self, request: &InsertRequests) -> usize {


I'm wondering if it's possible to read the payload size from protocol layer instead of calculating them ourselves. An extra pass to walk the entire data might be costly.

sunng87 · 2024-12-25T08:16:05Z

@waynexia client may still get tcp level error like send buffer is full if it sends faster than server can read.

github-actions bot added the docs-required This change requires docs update. label Dec 24, 2024

sunng87 mentioned this pull request Dec 24, 2024

Update docs for feat: introduct Limiter to limit in-flight write bytes size in frontend GreptimeTeam/docs#1400

Open

zyy17 changed the title ~~feat: introduct Limiter to limit in-flight write bytes size in frontend~~ feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. Dec 24, 2024

sunng87 mentioned this pull request Dec 24, 2024

Update docs for feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. GreptimeTeam/docs#1401

Closed

zyy17 force-pushed the feat/fe-max-inflight-bytes branch 6 times, most recently from b2f1017 to 530ca82 Compare December 25, 2024 04:36

zyy17 marked this pull request as ready for review December 25, 2024 04:57

zyy17 requested a review from a team as a code owner December 25, 2024 04:57

zyy17 force-pushed the feat/fe-max-inflight-bytes branch from 530ca82 to de7854e Compare December 25, 2024 05:24

zyy17 requested review from sunng87, waynexia and shuiyisong and removed request for a team December 25, 2024 06:10

waynexia reviewed Dec 25, 2024

View reviewed changes

sunng87 approved these changes Dec 25, 2024

View reviewed changes

feat: introduct Limiter to limit in-flight write bytes size in frontend

f4cf082

zyy17 force-pushed the feat/fe-max-inflight-bytes branch from de7854e to f4cf082 Compare December 25, 2024 08:05

waynexia approved these changes Dec 25, 2024

View reviewed changes

waynexia added this pull request to the merge queue Dec 25, 2024

Merged via the queue into GreptimeTeam:main with commit 5e88c80 Dec 25, 2024
44 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. #5231

feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. #5231

zyy17 commented Dec 24, 2024

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 25, 2024 •

edited

Loading

waynexia left a comment

waynexia Dec 25, 2024

sunng87 commented Dec 25, 2024

feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. #5231

feat: introduce the Limiter in frontend to limit the requests by in-flight write bytes size. #5231

Conversation

zyy17 commented Dec 24, 2024

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 25, 2024 • edited Loading

Codecov Report

waynexia left a comment

Choose a reason for hiding this comment

waynexia Dec 25, 2024

Choose a reason for hiding this comment

sunng87 commented Dec 25, 2024

codecov bot commented Dec 25, 2024 •

edited

Loading