-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log-query): implement pagination with limit and offset parameters #5241
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/query/src/log_query/planner.rs:97
- Ensure that the default value for
skip
is tested when it isNone
.
query.limit.skip.unwrap_or(0),
src/query/src/log_query/planner.rs:98
- Ensure that the default value for
fetch
is tested when it isNone
.
Some(query.limit.fetch.unwrap_or(DEFAULT_LIMIT)),
src/log-query/src/log_query.rs:271
- [nitpick] The struct name 'Limit' is too generic and could cause confusion. It should be renamed to 'PaginationLimit'.
pub struct Limit {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5241 +/- ##
==========================================
- Coverage 83.94% 83.71% -0.23%
==========================================
Files 1198 1198
Lines 222969 223038 +69
==========================================
- Hits 187177 186724 -453
- Misses 35792 36314 +522 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Implement pagination with limit and offset parameters. A similar use case in Elasticsearch is
/my-index-000001/_search?from=40&size=20
This is a breaking change but since
log-query
is highly experimental I only categorize it as a normal change.PR Checklist
Please convert it to a draft if some of the following conditions are not met.