-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support to convert time string to timestamp in convert_value()
#5242
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5242 +/- ##
==========================================
- Coverage 83.94% 83.69% -0.25%
==========================================
Files 1198 1203 +5
Lines 222969 224251 +1282
==========================================
+ Hits 187177 187693 +516
- Misses 35792 36558 +766 |
b987c5a
to
d509c17
Compare
d509c17
to
c154090
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR supports converting the time string(for example,
2024-12-26 10:00:25.899
) to theTimestamp
type inconvert_value()
. It fixes the insert data error when users insert timestamp in string format by using a prepared statement. The logic is compatible with native MySQL.PR Checklist
Please convert it to a draft if some of the following conditions are not met.