Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support elasticsearch _bulk API to ingest logs #5261

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Dec 31, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Support elasticsearch _bulk API to ingest logs;
  2. Mock some elasticsearch APIs that are used for Logstash;

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Copy link
Contributor

coderabbitai bot commented Dec 31, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-required This change requires docs update. label Dec 31, 2024
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch 4 times, most recently from 7ca043b to c201c86 Compare January 4, 2025 05:54
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Jan 4, 2025
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch from c201c86 to a0ad334 Compare January 4, 2025 05:59
@zyy17 zyy17 marked this pull request as ready for review January 4, 2025 06:00
@zyy17 zyy17 requested a review from a team as a code owner January 4, 2025 06:00
@zyy17 zyy17 changed the title feat: support elasticsearch _bulk API to ingest logs by logstash feat: support elasticsearch _bulk API Jan 4, 2025
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Jan 4, 2025
@zyy17 zyy17 changed the title feat: support elasticsearch _bulk API feat: support elasticsearch _bulk API to ingest logs Jan 4, 2025
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 71 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (a1cd194) to head (f2d8ddf).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5261      +/-   ##
==========================================
- Coverage   84.07%   83.87%   -0.20%     
==========================================
  Files        1199     1203       +4     
  Lines      225088   226393    +1305     
==========================================
+ Hits       189233   189882     +649     
- Misses      35855    36511     +656     

@zyy17 zyy17 requested review from sunng87, paomian, waynexia and shuiyisong and removed request for a team January 6, 2025 02:58
Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. Is there any chance to specify and invoke pipeline during the ingestion process? We can address it in next patch.

src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Show resolved Hide resolved
src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
@waynexia waynexia requested a review from Copilot January 6, 2025 06:48
@waynexia waynexia added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Jan 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Show resolved Hide resolved
src/servers/src/elasticsearch.rs Show resolved Hide resolved
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch 3 times, most recently from 67a30ae to b4f3ef3 Compare January 6, 2025 11:16
@zyy17 zyy17 requested a review from sunng87 January 6, 2025 11:16
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch from b4f3ef3 to b8a48de Compare January 7, 2025 07:43
@zyy17
Copy link
Collaborator Author

zyy17 commented Jan 7, 2025

Looks mostly good to me. Is there any chance to specify and invoke pipeline during the ingestion process? We can address it in next patch.

It's already in the request parameter. You can use &pipeline_name=xxx to specify the pipeline. Default it's greptime_identity.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Can we add a http integration test for this API? Please refer to https://github.com/GreptimeTeam/greptimedb/blob/main/tests-integration/tests/http.rs

src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/elasticsearch.rs Show resolved Hide resolved
src/servers/src/elasticsearch.rs Outdated Show resolved Hide resolved
src/servers/src/http.rs Show resolved Hide resolved
src/servers/src/http/event.rs Outdated Show resolved Hide resolved
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch 3 times, most recently from a5a321c to f55c962 Compare January 8, 2025 08:45
@zyy17 zyy17 force-pushed the feat/support-es-write-apis branch from f55c962 to 29e3429 Compare January 8, 2025 10:04
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@killme2008 killme2008 enabled auto-merge January 8, 2025 14:54
@killme2008 killme2008 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into GreptimeTeam:main with commit 03a2e6d Jan 8, 2025
38 checks passed
@zyy17 zyy17 deleted the feat/support-es-write-apis branch January 9, 2025 01:09
v0y4g3r pushed a commit to v0y4g3r/greptimedb that referenced this pull request Jan 19, 2025
…5261)

* feat: support elasticsearch '_bulk' API to ingest logs

Signed-off-by: zyy17 <[email protected]>

* refactor: code review

* refactor: add metrics

---------

Signed-off-by: zyy17 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants