fix: handle insert default value

[discord9]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

• fix handling insert default values into flow
• add related sqlness tests
• ALSO, add fill default value for impure functions(like now()) in frontend(previously it's on datanode), so for default value like now() the result will be consistent

Future works

maybe put now()'s value into query context, and assign it in frontend, and fill default value using that info in datanode(so that wouldn't need to fill rows in frontend, improving perfmance) , but that would be too large a change to fit into current PR, so future works maybe can be track by #5296 ?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.
• API changes are backward compatible.
• Schema or data changes are backward compatible.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 76.45631% with 97 lines in your changes missing coverage. Please review.

Project coverage is 83.89%. Comparing base (c370b4b) to head (3445911).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5307      +/-   ##
==========================================
- Coverage   84.14%   83.89%   -0.26%     
==========================================
  Files        1181     1182       +1     
  Lines      221141   221529     +388     
==========================================
- Hits       186074   185844     -230     
- Misses      35067    35685     +618     

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (2)

• tests/cases/standalone/common/flow/flow_ins_default.result: Language not supported
• tests/cases/standalone/common/flow/flow_ins_default.sql: Language not supported

Comments suppressed due to low confidence (2)

src/flow/src/adapter/flownode_impl.rs:287

• Ensure that the FetchFromRow enum and its fetch method are covered by tests to verify their behavior.

enum FetchFromRow {

src/flow/src/adapter/table_source.rs:70

• The error message uses incorrect grammar: 'couldn't found'. It should be 'couldn't find'.

TableNotFoundSnafu { name: format!("Table name = {:?}, couldn't found table id", name), }

[waynexia]

I'm thinking if the default value should be filled in the flownode. For those inpure function (now() or random()) as default value, this can lead to wired results. A more proper way in my perspective is filling default value in the frontend before mirroring.

[discord9]

I'm thinking if the default value should be filled in the flownode. For those inpure function (now() or random()) as default value, this can lead to wired results. A more proper way in my perspective is filling default value in the frontend before mirroring.

If that's the case, then for i.e. mito engine, wouldn't it mean for dist's datanode, if each datanode have slight derivation in time(Or just different write request arrives in different times), then the default values being filled would be different for different regions in different datanode would have subtle different? Is this consider a bug or feature? see column_default_value function in mito worker?
edited: ok single source of truth transfer from datanode to frontend?
edited 2: ok at least for handle_statement_insert the default values are filled in frontend, but other paths like handle_table_insert or handle_metric_row_inserts or handle_row_inserts_with_create_type didn't handle fill default value, is this intentional or should we update all insert path to fill default values in frontend?