-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split up candidate registration and keep alive #5320
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
fdc1a29
to
0e0ec53
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5320 +/- ##
==========================================
- Coverage 84.14% 83.88% -0.26%
==========================================
Files 1181 1181
Lines 221141 221161 +20
==========================================
- Hits 186074 185528 -546
- Misses 35067 35633 +566 |
Candidate register and keep alive shoud be progressive, so it's simpler to put them into a function instead of split them up. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5208
What's changed and what's your intention?
A refactor that has been discussed before. For etcd it's relatively complicated since the keep alive is operated through a keep alive stream returned by lease client. So the keep alive is still operated inside the
candidate registration
.Not sure if it's the expected structure, so I just init a draft pr.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.