Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop useless import raw_normalize_path in object-store lib #5349

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

yihong0618
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

found when reading the storage code.
the opendal method pub use opendal::raw::{normalize_path as raw_normalize_path seems useless for now.

I search the commit this method bring from #1268
and drop from #2777

and I grep the code base seems there no other place use it, so maybe it can drop now.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@yihong0618 yihong0618 requested a review from a team as a code owner January 13, 2025 03:39
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jan 13, 2025
@yihong0618 yihong0618 changed the title chore: drop use less import raw_normalize_path in store lib chore: drop use less import raw_normalize_path in object-store lib Jan 13, 2025
Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yihong0618 yihong0618 changed the title chore: drop use less import raw_normalize_path in object-store lib chore: drop useless import raw_normalize_path in object-store lib Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (f069ea0) to head (7e6372d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5349      +/-   ##
==========================================
- Coverage   84.12%   83.88%   -0.25%     
==========================================
  Files        1181     1181              
  Lines      221027   221027              
==========================================
- Hits       185950   185418     -532     
- Misses      35077    35609     +532     

@sunng87 sunng87 added this pull request to the merge queue Jan 13, 2025
@sunng87
Copy link
Member

sunng87 commented Jan 13, 2025

LGTM. Why does cargo check or clippy is not reporting this?

Merged via the queue into GreptimeTeam:main with commit 03a144f Jan 13, 2025
44 checks passed
@yihong0618
Copy link
Contributor Author

yihong0618 commented Jan 13, 2025

LGTM. Why does cargo check or clippy is not reporting this?

no idea🤣

update: https://github.com/cpg314/cargo-workspace-unused-pub

v0y4g3r pushed a commit to v0y4g3r/greptimedb that referenced this pull request Jan 19, 2025
…eptimeTeam#5349)

chore: drop use less import raw_normalize_path in store lib

Signed-off-by: yihong0618 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants