Skip to content

Commit

Permalink
fix: ci chart testing (#103)
Browse files Browse the repository at this point in the history
* fix: ci chart testing

* chore: test install

* chore: test install

* chore: test install

* chore: set 'ct lint validate-maintainers=false'

* fix: run script symbol

* fix: charts dir notfound

* refactor: Modify ci test

* chore: ready for review
  • Loading branch information
daviderli614 authored Jan 23, 2024
1 parent b326eb4 commit 75b9bb7
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,15 @@ jobs:
- name: Run chart-testing (lint)
if: steps.list-changed.outputs.changed == 'true'
run: ct lint --target-branch ${{ github.event.repository.default_branch }}
run: ct lint --validate-maintainers=false --target-branch ${{ github.event.repository.default_branch }}

- name: Create kind cluster
if: steps.list-changed.outputs.changed == 'true'
uses: helm/[email protected]
with:
wait: 120s

- name: Run chart-testing (install)
- name: Run e2e
if: steps.list-changed.outputs.changed == 'true'
run: ct install --chart-dirs charts --target-branch ${{ github.event.repository.default_branch }}
run: |
make e2e
10 changes: 5 additions & 5 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: E2E Test
name: E2E

on:
workflow_dispatch:
Expand All @@ -23,10 +23,10 @@ jobs:
with:
version: v3.12.1

- name: Setup e2e environment
shell: bash
run: |
.github/scripts/setup-e2e-env.sh
- name: Create kind cluster
uses: helm/[email protected]
with:
wait: 120s

- name: Deploy greptimedb-cluster chart
if: ${{ github.event.inputs.chart == 'greptimedb-cluster' }}
Expand Down
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,8 @@ check-docs: docs ## Check docs
@git diff --quiet || \
(echo "Need to update documentation, please run 'make docs'"; \
exit 1)

.PHONY: e2e
e2e: ## Run e2e tests.
.github/scripts/deploy-greptimedb-cluster.sh
.github/scripts/deploy-greptimedb-standalone.sh

0 comments on commit 75b9bb7

Please sign in to comment.