-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump operator version to v0.1.3-alpha.1 #180
Conversation
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
charts/greptimedb-operator/Chart.yaml (1)
5-5
: Note: This is a pre-release alpha version.The
alpha
designation indicates this version may include experimental features and is not recommended for production use. Users should exercise caution when upgrading.charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (1)
2931-2943
: Consider adding default values for slowQuery configurationWhile the schema validation is solid, consider documenting or providing default values for:
- sampleRatio (e.g., 0.1 for 10% sampling)
- threshold (e.g., "1s" for 1 second)
This would help users get started with slow query logging without having to determine appropriate values themselves.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- charts/greptimedb-operator/Chart.yaml (1 hunks)
- charts/greptimedb-operator/README.md (2 hunks)
- charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (12 hunks)
- charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (2 hunks)
- charts/greptimedb-operator/values.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- charts/greptimedb-operator/README.md
🔇 Additional comments (6)
charts/greptimedb-operator/Chart.yaml (1)
5-6
: LGTM! Version updates look correct.The version bumps follow semantic versioning conventions:
- appVersion: 0.1.3-alpha.1 (pre-release version)
- Chart version: 0.2.9
Let's verify the version consistency across related files:
✅ Verification successful
Version updates are consistent across all chart files ✅
The version references are correctly synchronized in all relevant files:
- Chart.yaml: appVersion: 0.1.3-alpha.1, version: 0.2.9
- values.yaml: image.tag: v0.1.3-alpha.1
- README.md: Both versions correctly reflected in badges and configuration table
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency across chart files echo "Checking version references in README.md and values.yaml..." rg -A 1 "0\.1\.3-alpha\.1|0\.2\.9" charts/greptimedb-operator/Length of output: 1111
charts/greptimedb-operator/values.yaml (1)
11-11
: Version bump looks correct, but please note this is an alpha release.The version bump from
v0.1.2
tov0.1.3-alpha.1
is consistent with the changes in Chart.yaml. However, as this is an alpha release, users should be aware that it may contain unstable features.Let's verify version consistency across related files:
✅ Verification successful
Version consistency verified across Helm chart files
The version
v0.1.3-alpha.1
is consistently referenced across:
- values.yaml:
tag: v0.1.3-alpha.1
- Chart.yaml:
appVersion: 0.1.3-alpha.1
- README.md:
image.tag | string | "v0.1.3-alpha.1"
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency across Helm chart files echo "Checking version references in Chart.yaml and README.md..." rg -A 1 "version:|appVersion:" charts/greptimedb-operator/Chart.yaml rg "v0.1.3-alpha.1" charts/greptimedb-operator/README.mdLength of output: 373
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (2)
2048-2125
: LGTM! Well-structured startup probe configuration.The addition of
startupProbe
follows Kubernetes API conventions and includes all necessary probe configurations (exec, http, tcp, grpc) with proper type definitions and validations. This is a valuable addition that will help handle slow-starting containers better than just relying on liveness and readiness probes.
2944-2956
: LGTM! Well-defined slow query logging configuration.The
slowQuery
configuration under logging section is well-structured with:
- Clear boolean toggle with
enabled
field- Precise pattern validation for
sampleRatio
(0-1)- Proper time duration format validation for
threshold
This addition will help in monitoring and debugging query performance issues.
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (2)
2060-2137
: LGTM: Well-structured startupProbe schema additionsThe startupProbe schema follows Kubernetes probe schema conventions and includes all standard probe fields:
- exec, httpGet, tcpSocket, and gRPC handlers
- Common timing fields (initialDelaySeconds, periodSeconds, etc.)
- Proper type definitions and validation
Also applies to: 4974-5051, 7862-7939, 10780-10857
2931-2943
: LGTM: Well-defined slowQuery schema additionsThe slowQuery schema is consistently defined across datanode, flownode, and frontend sections with:
- Required
enabled
boolean field- Optional
sampleRatio
field with proper regex pattern validation^(0?\.\d+|1(\.0+)?)$
for decimal values between 0 and 1- Optional
threshold
field with proper regex pattern validation^([0-9]+(\.[0-9]+)?(ns|us|µs|ms|s|m|h))+$
for duration valuesAlso applies to: 5841-5853, 8734-8746
Summary by CodeRabbit
Release Notes
New Features
startupProbe
andslowQuery
configurations in theGreptimeDBCluster
andGreptimeDBStandalone
resources for improved health checks and logging capabilities.Version Updates
0.1.3-alpha.1
and the Helm chart version to0.2.9
.Documentation