Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(greptimedb-operator): release greptimedb-operator v0.1.3-alpha.8 #202

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Nov 22, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced rollingUpdate properties in the GreptimeDBCluster and GreptimeDBStandalone configurations for enhanced deployment strategies.
  • Version Updates

    • Updated application version to 0.1.3-alpha.8 and chart version to 0.2.12 across relevant documentation and configuration files.
  • Bug Fixes

    • Corrected image tag in configuration files to reflect the latest version.

Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Walkthrough

The pull request includes updates to the greptimedb-operator Helm chart, specifically modifying versioning information across several files. The Chart.yaml and README.md files reflect an increment in the application version from 0.1.3-alpha.6 to 0.1.3-alpha.8 and the chart version from 0.2.11 to 0.2.12. Additionally, new rollingUpdate fields have been added to the CustomResourceDefinitions for GreptimeDBCluster and GreptimeDBStandalone, enhancing their deployment strategies.

Changes

File Change Summary
charts/greptimedb-operator/Chart.yaml Updated appVersion from 0.1.3-alpha.6 to 0.1.3-alpha.8; updated version from 0.2.11 to 0.2.12.
charts/greptimedb-operator/README.md Updated image.tag from "v0.1.3-alpha.6" to "v0.1.3-alpha.8"; updated version and appVersion to 0.2.12 and 0.1.3-alpha.8.
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml Added rollingUpdate field to datanode, flownode, frontend, and meta sections with maxUnavailable and maxSurge properties.
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml Added rollingUpdate property with maxUnavailable and partition sub-properties to GreptimeDBStandalone CRD.
charts/greptimedb-operator/values.yaml Updated tag from v0.1.3-alpha.6 to v0.1.3-alpha.8.

Possibly related PRs

Suggested reviewers

  • daviderli614

🐰 In the meadow, hops a rabbit bright,
With version updates, oh what a sight!
From alpha six to eight we leap,
Rolling updates, our promise to keep.
In charts and YAML, we dance and play,
Enhancing our clusters, hip-hip-hooray! 🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zyy17 zyy17 requested a review from daviderli614 November 22, 2024 08:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)

3185-3195: Consider adding field descriptions for better user experience.

While the schema is technically correct, adding descriptions for the rollingUpdate fields would help users understand their purpose and usage.

Apply this diff to add descriptions:

                 rollingUpdate:
                   properties:
                     maxUnavailable:
+                      description: "The maximum number of pods that can be unavailable during the update. Value can be an absolute number (ex: 5) or a percentage of desired pods (ex: 10%)."
                       anyOf:
                         - type: integer
                         - type: string
                       x-kubernetes-int-or-string: true
                     partition:
+                      description: "Partition indicates the ordinal at which the StatefulSet should be partitioned for updates. Update will only be applied to pods numbered greater than or equal to the partition value."
                       format: int32
                       type: integer
                   type: object
charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (1)

3078-3088: LGTM! Well-designed rolling update configuration.

The rollingUpdate implementations follow Kubernetes best practices:

  • StatefulSet components (datanode, flownode, meta) correctly use maxUnavailable and partition
  • Frontend component appropriately includes maxSurge for Deployment-style updates

The differentiation between frontend (Deployment) and other components (StatefulSets) is a good architectural choice:

  • Frontend can handle elastic scaling with maxSurge
  • StatefulSet components maintain ordered updates with partition

Also applies to: 6128-6138, 9171-9183, 12284-12296

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 608a18e and df18bc2.

📒 Files selected for processing (5)
  • charts/greptimedb-operator/Chart.yaml (1 hunks)
  • charts/greptimedb-operator/README.md (2 hunks)
  • charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (5 hunks)
  • charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1 hunks)
  • charts/greptimedb-operator/values.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • charts/greptimedb-operator/Chart.yaml
  • charts/greptimedb-operator/README.md
  • charts/greptimedb-operator/values.yaml
🔇 Additional comments (1)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)

3185-3195: LGTM! The rollingUpdate schema follows Kubernetes conventions.

The implementation properly defines the rolling update strategy with:

  • maxUnavailable: Supports both integer and percentage values
  • partition: Uses the correct int32 format for ordinal-based updates

@zyy17 zyy17 merged commit 900c5e0 into GreptimeTeam:main Nov 22, 2024
3 checks passed
@zyy17 zyy17 deleted the chore/upgrade-operator branch November 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants