-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(greptimedb-operator): release greptimedb-operator v0.1.3-alpha.8 #202
Conversation
WalkthroughThe pull request includes updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)
3185-3195
: Consider adding field descriptions for better user experience.While the schema is technically correct, adding descriptions for the
rollingUpdate
fields would help users understand their purpose and usage.Apply this diff to add descriptions:
rollingUpdate: properties: maxUnavailable: + description: "The maximum number of pods that can be unavailable during the update. Value can be an absolute number (ex: 5) or a percentage of desired pods (ex: 10%)." anyOf: - type: integer - type: string x-kubernetes-int-or-string: true partition: + description: "Partition indicates the ordinal at which the StatefulSet should be partitioned for updates. Update will only be applied to pods numbered greater than or equal to the partition value." format: int32 type: integer type: objectcharts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml (1)
3078-3088
: LGTM! Well-designed rolling update configuration.The rollingUpdate implementations follow Kubernetes best practices:
- StatefulSet components (datanode, flownode, meta) correctly use maxUnavailable and partition
- Frontend component appropriately includes maxSurge for Deployment-style updates
The differentiation between frontend (Deployment) and other components (StatefulSets) is a good architectural choice:
- Frontend can handle elastic scaling with maxSurge
- StatefulSet components maintain ordered updates with partition
Also applies to: 6128-6138, 9171-9183, 12284-12296
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
charts/greptimedb-operator/Chart.yaml
(1 hunks)charts/greptimedb-operator/README.md
(2 hunks)charts/greptimedb-operator/templates/crds/crd-greptimedbcluster.yaml
(5 hunks)charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml
(1 hunks)charts/greptimedb-operator/values.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- charts/greptimedb-operator/Chart.yaml
- charts/greptimedb-operator/README.md
- charts/greptimedb-operator/values.yaml
🔇 Additional comments (1)
charts/greptimedb-operator/templates/crds/crd-greptimedbstandalone.yaml (1)
3185-3195
: LGTM! The rollingUpdate schema follows Kubernetes conventions.
The implementation properly defines the rolling update strategy with:
maxUnavailable
: Supports both integer and percentage valuespartition
: Uses the correct int32 format for ordinal-based updates
Summary by CodeRabbit
Release Notes
New Features
rollingUpdate
properties in theGreptimeDBCluster
andGreptimeDBStandalone
configurations for enhanced deployment strategies.Version Updates
0.1.3-alpha.8
and chart version to0.2.12
across relevant documentation and configuration files.Bug Fixes