Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link order #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix link order #2

wants to merge 2 commits into from

Conversation

jiacai2050
Copy link
Contributor

From https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script

the order of arguments passed to rustc may affect the order of arguments passed to the linker. Therefore, you will want to pay attention to the order of the build script’s instructions. For example, if object foo needs to link against library bar, you may want to make sure that library bar’s cargo::rustc-link-lib instruction appears after instructions to link object foo.

@jiacai2050
Copy link
Contributor Author

The fix will make ci pass, see https://github.com/jiacai2050/vsag-sys/actions/runs/11705365423/job/32599950701

@killme2008 killme2008 requested a review from zhongzc November 7, 2024 02:44
@zhongzc zhongzc added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Nov 7, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc Awaiting requested review from zhongzc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiacai2050