feat[next]: Extend astype to work with tuples #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninaburg
force-pushed
the
extend_astype_with_tuples
branch
from
3823227 to
048d4c0
Compare
|
cscs-ci run |
|
cscs-ci run |
nfarabullini
approved these changes
Oct 20, 2023
|
cscs-ci run |
tehrengruber
requested changes
Oct 20, 2023
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_type_deduction.py
Outdated
Show resolved
Hide resolved
tests/next_tests/unit_tests/ffront_tests/foast_passes_tests/test_type_alias_replacement.py
Outdated
Show resolved
Hide resolved
added 5 commits
October 20, 2023 22:16
|
cscs-ci run |
tehrengruber
requested changes
Oct 21, 2023
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run |
tehrengruber
requested changes
Nov 15, 2023
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
ninaburg
force-pushed
the
extend_astype_with_tuples
branch
from
779ae8b to
4a11354
Compare
|
cscs-ci run |
tehrengruber
approved these changes
Nov 17, 2023
| def cast_tuple( | ||
| a: cases.IFloatField, | ||
| b: cases.IFloatField, | ||
| a_casted_to_int_outside_of_gt4py: cases.IField, |
There was a problem hiding this comment.
Suggested change
| a_casted_to_int_outside_of_gt4py: cases.IField, | |
| a_asint: cases.IField, |
The naming was not a serious proposal of mine, but just to signify what it meant. Here it should be clear from the context.
|
|
||
| a = cases.allocate(cartesian_case, cast_tuple, "a")() | ||
| b = cases.allocate(cartesian_case, cast_tuple, "b")() | ||
| a_casted_to_int_outside_of_gt4py = gtx.np_as_located_field(IDim)(np.asarray(a).astype(int32)) |
There was a problem hiding this comment.
Suggested change
| a_casted_to_int_outside_of_gt4py = gtx.np_as_located_field(IDim)(np.asarray(a).astype(int32)) | |
| a_asint = gtx.np_as_located_field(IDim)(np.asarray(a).astype(int32)) |
As above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the functionality of the built-in
astypefunction in theffrontmodule such that we can writefield_float32, field_float32 = astype((field_float64, field_float64), float32). The changes specifically impact thefoast_to_itir.pyfile. Here's an overview of the modifications:astypefunction's argument and return types have been extended to accept tuples of fields in addition to individual fields.foast_to_itir.pyfile, when casting tuples, each element is processed individually. The casted elements are then combined into a new tuple usingmake_tuple.astypefunction correctly handles tuples of fields.The motivation for these changes is to simplify and enhance code readability when performing operations that mix different types. In such scenarios, explicit type promotion is required, resulting in cluttered stencils with casting operations. This update makes the type conversion explicit and visible, reducing the need for extensive casting operations and improving code clarity.