Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next]: Extend DaCe support for offset providers #1353

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Oct 20, 2023

Description

Extend support in DaCe backend for offset providers, in order to generate the tasklet code in case of shift expressions with both direct and indirect addressing.

This allows to visit expressions like:

⟪C2E2Cₒ, 0ₒ, Koffₒ, ·⟪C2CECₒ, 0ₒ⟫(zd_vertoffset)⟫(theta_v)

which originates from user code:

theta_v(as_offset(Koff, zd_vertoffset(C2CEC[0]) + int32(1)))

@edopao edopao marked this pull request as ready for review October 20, 2023 19:43
@edopao edopao requested a review from petiaccja October 20, 2023 19:43
@edopao edopao requested a review from petiaccja October 25, 2023 07:37
@edopao
Copy link
Contributor Author

edopao commented Oct 25, 2023

cscs-ci run

@edopao edopao force-pushed the dace-shift_offsets branch from 165e134 to 61c538e Compare October 27, 2023 15:48
Copy link
Contributor

@petiaccja petiaccja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment on the new visit_OffsetLiteral, otherwise I like the way you restructured the _visit_shift, and the PR is good to go IMO.

@edopao edopao requested a review from petiaccja October 30, 2023 13:10
@edopao edopao merged commit 0650d77 into GridTools:main Oct 30, 2023
18 checks passed
@edopao edopao deleted the dace-shift_offsets branch October 30, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants