fix[dace]: Fixed SDFG args #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the arguments were extracted based on the `arg_names` member of the SDFG. However it was noticed that some transformation would add new arguments, especially the `SDFG.apply_gpu_transformation()`, to the SDFG. Before, the extraction of the call arguments was based on the `SDFG.arg_names` member, but since that member was populated before the transformations were applied, it was out of date at the end of the `build_sdfg_from_itir()` function. Thus in this commit the computation of the required call arguments is based on the `signature_arglist()` function of the SDFG.
Before the argument list, i.e. the arguments that could be passed as positional argument, include all arguments of the SDFG. However, due to several reasons it was changed to only include the arguments that where known to the Fencil as positional arguments. The other arguments, such as offset providers and the ones generated by the translation process, are only accessible as keywords only arguments.
In commit d916497 I thought it was necessary to use `SDFG.signature_arglist()` instead of `SDFG.arg_names`, as it turned out it was enough to give the SDFG the correct argument list. I also updated the composition of `expected_args`, now it will be an error if an argument is missing. It now works.
|
cscs-ci run |
edopao
approved these changes
Dec 19, 2023
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified how the SDFG arguments are computed.
It was noticed that some transformations, especially the
SDFG.apply_gpu_transformation(), to the SDFG, added new arguments to the SDFG.But, since a lot of functions build on the
SDFG.arg_namesmember and this member was populated before the transformation, an error occurred.Thus it was changed such that
SDFG.arg_nameswas only populated with the arguments also known to the Fencil.