fix[cartesian]: DaCe array access in tasklet #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found some incompatible tasklet represention while upgrading to dace v0.15.1. Array access inside tasklet with partial index subset worked in v0.14.1, although not valid. Added view or transient array in case of memlet slice, to ensure that tasklet uses explicit indexes for the full array shape.
edopao
changed the title
|
cscs-ci run |
|
cscs-ci run |
|
All problems have been fixed. Coding done, ready for review. |
FlorianDeconinck
approved these changes
Jan 16, 2024
| if dim_size == 1 | ||
| ] | ||
| if len(memlet_data_index) < array_ndims: | ||
| """ |
There was a problem hiding this comment.
Maybe move this comment at the top of the new for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some incompatible tasklet represention while upgrading to dace v0.15.1. Array access inside tasklet with partial index subset worked in v0.14.1, although not valid.
Here is an example of tasklet with partial index subset:
In case of a mapped tasklet, the memlet's closest source/endpoint is a map entry/exit node, like in this other example:
The fix consists of modifying the memlets to pass the full array shape to such tasklet, and use all explicit indices inside the tasklet to access the array. This is the right representation in DaCe SDFG, as discussed with the DaCe developers.
The two tasklet cases shown above, with this fix, become:
and:
This fix is covered by the following test cases, which would otherwise fail with dace v0.15.1: