Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature[next]: add support for Python3.11 fixing typing-related bugs #1418

Merged
merged 13 commits into from
Jan 19, 2024

Conversation

egparedes
Copy link
Contributor

Fixes hidden bugs in datamodels and extended_typing to support Python 3.11.

Actual bug fixes:

  • Previous fix to support typing.Any implementation as a class (python/cpython@5a4973e) didn't work in 3.11.
  • Partially concretization of generic datamodels replacing typevars was broken.
  • Partially concretization of generic datamodels leaving some parameters as typevars was broken.

Other changes:

  • Add python 3.11 as supported version.
  • Remove dead code in comments.
  • Fix some imports style to comply with our coding guidelines.

Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egparedes egparedes merged commit 90e5d5a into GridTools:main Jan 19, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants